Skip to content

WIP: update fmt (>=10.2.1) and spdlog (>=1.13)#2279

Closed
jameslamb wants to merge 8 commits intorapidsai:branch-24.08from
jameslamb:update-fmt-and-spdlog
Closed

WIP: update fmt (>=10.2.1) and spdlog (>=1.13)#2279
jameslamb wants to merge 8 commits intorapidsai:branch-24.08from
jameslamb:update-fmt-and-spdlog

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Apr 25, 2024 •
edited
Loading

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 2 - In Progress Currenty a work in progress labels Apr 25, 2024
@jameslamb jameslamb mentioned this pull request Apr 25, 2024
Closed
7 tasks
@github-actions github-actions bot added the ci label Apr 26, 2024
@jameslamb jameslamb mentioned this pull request Apr 26, 2024
Merged
@jameslamb jameslamb mentioned this pull request Apr 26, 2024
Closed
@jameslamb
Copy link
Member Author

jameslamb commented Apr 29, 2024

The CUDA 12.x conda-python-tests jobs are failing here, like this:

ImportError while importing test module '/__w/raft/raft/python/pylibraft/pylibraft/test/test_brute_force.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/conda/envs/test/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test/test_brute_force.py:21: in <module>
    from pylibraft.neighbors.brute_force import knn
/opt/conda/envs/test/lib/python3.11/site-packages/pylibraft/neighbors/__init__.py:16: in <module>
    from pylibraft.neighbors import brute_force  # type: ignore
E   ImportError: libnvJitLink.so.12: cannot open shared object file: No such file or directory

(build link)

That looks unrelated to these changes. I see the same issues on other recent PRs:

rapids-bot bot pushed a commit that referenced this pull request May 3, 2024
@jameslamb
define 'ucx' pytest marker (#2281)
da3b9a9 
Looking through logs on #2279, I noticed this warning:

```text
test/test_comms.py:267
  /__w/raft/raft/python/raft-dask/raft_dask/test/test_comms.py:267: PytestUnknownMarkWarning: Unknown pytest.mark.ucx - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.ucx
```

([build link](https://github.com/rapidsai/raft/actions/runs/8850602382/job/24314273393?pr=2279#step:7:780))

This resolves it.

### How I tested this

Looked for all such cases like this:

```shell
git grep -E 'mark.*ucx'
```

Hopefully we'll see this log disappear from the `conda-python-tests` CI logs on this PR.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Ray Douglass (https://github.com/raydouglass)

URL: #2281
@jameslamb jameslamb changed the base branch from branch-24.06 to branch-24.08 May 21, 2024 14:42
@jameslamb jameslamb mentioned this pull request Jul 18, 2024
Open
@jameslamb
Copy link
Member Author

jameslamb commented Jul 18, 2024

This work is paused, in favor of pursuing a better long-term solution in the future. Closing this PR for now.

Subscribe to rapidsai/build-planning#54 and rapidsai/build-planning#56 for updates.

@jameslamb jameslamb closed this Jul 18, 2024
loulankxh pushed a commit to loulankxh/raft that referenced this pull request Oct 14, 2025
@jameslamb
define 'ucx' pytest marker (rapidsai#2281)
7375cfd 
Looking through logs on rapidsai#2279, I noticed this warning:

```text
test/test_comms.py:267
  /__w/raft/raft/python/raft-dask/raft_dask/test/test_comms.py:267: PytestUnknownMarkWarning: Unknown pytest.mark.ucx - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.ucx
```

([build link](https://github.com/rapidsai/raft/actions/runs/8850602382/job/24314273393?pr=2279#step:7:780))

This resolves it.

### How I tested this

Looked for all such cases like this:

```shell
git grep -E 'mark.*ucx'
```

Hopefully we'll see this log disappear from the `conda-python-tests` CI logs on this PR.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#2281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jameslamb jameslamb

Labels

2 - In Progress Currenty a work in progress ci CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

Unstructured Data Processing
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jameslamb